[dnstap] 'cache_status' field (was: Re: suggested optional fields for DNSTAP)

[Robert Edmonds]

Joseph Gersch wrote:
> > On Feb 27, 2015, at 3:52 PM, Robert Edmonds <edmonds at mycre.ws> wrote:
> > What do you think about adding a new enum type to the dnstap.proto
> > definitions:
> > 
> >    enum CacheStatus {
> >        // The response message could not be generated entirely from
> >        // cached information.
> >        CACHE_MISS = 1;
> > 
> >        // The response message was generated by consulting a
> >        // whole-message cache of DNS responses.
> >        CACHE_HIT_MESSAGE = 2;
> > 
> >        // The response message was generated entirely by consulting a
> >        // cache of DNS records.
> >        CACHE_HIT_RECORD = 3;
> >    }
> > 
> > and then adding a new optional field of that type to the "Message" type:
> > 
> >    message Message {
> >        // [...elided...]
> > 
> >        optional CacheStatus        cache_status = 15;
> >    }
> > 
> > This would allow extending CacheStatus to new types of cache hits in the
> > future, too.
> 
> You give a strong argument as to why it should be ENUM instead of BOOLEAN, and I agree with you.  

Great, here's the tracking issue:

    https://github.com/dnstap/dnstap.pb/issues/2

-- 
Robert Edmonds